feat(site): update doc-core to 1.22.0#4946
Conversation
Deploying patternfly-org with
|
| Latest commit: |
f6ec840
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://586e2e2f.patternfly-org.pages.dev |
| Branch Preview URL: | https://update-doc-core-1-15-4.patternfly-org.pages.dev |
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
does this change mean that composing pages with embedded react components should be constructed or located differently than before? that'll be important to communicate to Erin.
| import React from 'react'; | ||
| import { Link as ReachLink, navigate } from '@reach/router'; | ||
| import { getAsyncComponent } from '../../routes'; | ||
| const { getAsyncComponent } = require('../../routes'); |
There was a problem hiding this comment.
I don't understand why you'd be mixing import and require() in the same file
There was a problem hiding this comment.
Because some of the files we're importing from are ESM and some are CJS
packages/site/package.json
Outdated
| "ci:build": "yarn generate:content && yarn build", | ||
| "clean": "rm -rf src/generated", | ||
| "generate:content": "patternfly-doc-core convert-to-mdx ../documentation-site/patternfly-docs/content/", | ||
| "generate:content": "rm -rf src/content && cp -r ../documentation-site/patternfly-docs/content src/content", |
There was a problem hiding this comment.
does doc-core 1.20.0 handle .md files natively now without needing to convert to mdx?
There was a problem hiding this comment.
It doesn't handle them natively per se, but it does now include the conversion internally in its build pipeline
packages/site/package.json
Outdated
| "astro": "^5.16.10" | ||
| "@patternfly/patternfly-doc-core": "^1.20.0", | ||
| "@patternfly/react-icons": "^6.5.0-prerelease.14", | ||
| "astro": "^5.15.9" |
There was a problem hiding this comment.
Is this an intentional bump down for the astro version?
wise-king-sullyman
changed the title
| "ci:build": "yarn generate:content && yarn build", | ||
| "clean": "rm -rf src/generated", | ||
| "generate:content": "patternfly-doc-core convert-to-mdx ../documentation-site/patternfly-docs/content/", | ||
| "generate:content": "rm -rf src/content && mkdir -p src/content && cp -r ../documentation-site/patternfly-docs/content src/content", |
There was a problem hiding this comment.
I think there's a nesting bug here
cp -r ../documentation-site/patternfly-docs/content src/content will copy the content directory into src/content/, giving you src/content/content/... instead of src/content/....
You'd want either:
rm -rf src/content && cp -r ../documentation-site/patternfly-docs/content src/content(skip the mkdir -p and let cp create the target)rm -rf src/content && mkdir -p src/content && cp -r ../documentation-site/patternfly-docs/content/* src/content/to copy the contents instead of the directory itself.
| --- | ||
| id: About us | ||
| title: About us | ||
| section: Get started |
There was a problem hiding this comment.
I don't think this should move to the Get started section. This is something that I believe Erin moved above the getting started section on staging on purpose
3 participants
Closes #4930